Add support for isLabelWrapped and component in Checkbox / Radio #9830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamviktora
requested review from
jenny-s51,
mcoker,
tlabaj,
a team and
kmcfaul
and removed request for
a team and
jenny-s51
|
Preview: https://patternfly-react-pr-9830.surge.sh A11y report: https://patternfly-react-pr-9830-a11y.surge.sh |
tlabaj
requested changes
Jan 8, 2024
@andrew-ronaldson @mcoker is this something we want to support for checkbox? |
thatblindgeye
approved these changes
Jan 8, 2024
mcoker
reviewed
Jan 8, 2024
| </label> | ||
| ); | ||
| } | ||
| const wrapWithLabel = isLabelWrapped && !component; |
There was a problem hiding this comment.
Just a thought, if the user passes component="label" then they'll end up with nested label elements. We could treat component="label" and isLabelWrapped the same.
Suggested change
| const wrapWithLabel = isLabelWrapped && !component; | |
| const wrapWithLabel = isLabelWrapped && (!component || component === 'label'); |
There was a problem hiding this comment.
This is a good idea! We could possibly remove the isLabelWrapped prop as a breaking change in v6 and replace it entirely with just component="label"
mcoker
approved these changes
Jan 8, 2024
| /** Flag to show if the checkbox label is wrapped on small screen. Will only apply if component prop is not specified. */ | ||
| isLabelWrapped?: boolean; | ||
| /** Flag to show if the checkbox label is shown before the checkbox button. */ | ||
| isLabelBeforeButton?: boolean; |
There was a problem hiding this comment.
This is fine but I wonder if in a breaking change we should rename this and the radio to remove the "button" part and use something more generic. isLabelBeforeInput would probably be more accurate, but it could just be isLabelStart or something along those lines - do we have any kind of pattern for naming props like this? This prop is a boolean, but the button and accordion have props iconPosition="[start/end]" and togglePosition=[start/end] that do something similar.
There was a problem hiding this comment.
I checked the core docs and it has a "Reversed" example, so possibly isReversed or isLabelReversed?
I wonder whether we rename it now to have less codemods, or just keep it consistent in v5 so we keep the isLabelBeforeButton to match the Radio prop.
…the same as isLabelWrapped
|
Thanks everybody for your reviews! I have one question regarding V6 - should I open a new PR to address the same changes to V6 branch? Or is the V6 somehow being rebased on the main branch automatically? |
kmcfaul
added a commit
that referenced
this pull request
Jan 25, 2024
* fix(RTL): added right-to-left page demo (#9694) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Wizard): onStepChange - skip isDisabled & isHidden (#9748) * fix(Text input): Added aria-expanded (#9705) * fix(Text input): Added aria-expanded * add interface * updates from review * fix(Notification Drawer): Added screen reader text for notification drawer item read state (#9569) * fix(Notification Drawer): Added screen reader text for notification drawer item read state * fix snapshot * Update prop description * add aria-live * update snapshots * feat(Wizard): ability to add props to WizardFooter buttons (#9709) * feat: ability to add props to WizardFooter buttons * fix(WizardFooter): null check * fix(Wizard): simpler design of adding footer buttons props * test(Wizard): can add props to footer buttons * docs(WizardFooter): move comment so docs have correct description * refactor(WizardFooter): move FooterButtonProps to types file * chore(Divider): update tests to new standards (#9714) * chore(Divider): update tests to new standards * changes from PR review * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(TreeView): define button type (#9770) * bug(build): fixed built ESM files importing CJS files from react-styles (#9347) * bug(build): fixed built ESM files importing CJS files from react-styles * edited yarn.lock to invalidate deps cache in GH actions * excluded file extensions from react-styles path transform in ESM build * updated jest config to transform .mjs files * updated pr action to invalidate deps cache if package files added/edited * chore(deps): Add ts-node to support executing typescript files directly * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - [email protected] * chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.4 (#9780) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * feat(Datalist): implement full page Basic demo to match HTML #9048 (#9087) * feat(Datalist): implement full page Basic demo to match HTML #9048 * fix syntax error * comments applied * comments applied * comments applied * comments applied * \xa0 comments applied * move key per review comments * address PR comments * revert change to package.json * Converted basic demo to TS --------- Co-authored-by: nicolethoen <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> * fix(ClipboardCopy): kepp caret position (#9772) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9757) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.5 (#9806) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update devdependencies (#9800) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(DatePicker): updated logic for parsing and focus management (#9794) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(PrimaryDetail): convert demos to TS (#9787) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(misc): clean up instances of Array.apply (#9798) * clean up instances of Array.apply * rename item to value * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(eslint): Added React Testing Library linter plugin (#9805) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(DataList): update tests (#9672) * add spread prop test, update test * chore(DataList): update tests * fix merge error * break out into separate files, pr feedback * updates * fix some example ids * minor test updates * revert action change * bug(ClipboardCopy): change children type to string (#9743) * bug(ClipboardCopy): change children type to string Signed-off-by: gitdallas <[email protected]> * fix clipboardcopyexpanded to work with string children Signed-off-by: gitdallas <[email protected]> * refactor a bit * fix bad rebase --------- Signed-off-by: gitdallas <[email protected]> * chore(deps): update devdependencies (#9817) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix Search Input - composable advanced search demo (#9484) * Search Input - composable advanced search fix date * remove isFill from datePicker * docs(custom menu): add example with search input inline filtering (#9687) * docs(custom menu): add example with search input inline filtering * refactor(demo menu): rename to InlineSearchFilterMenuDemo * chore(HelperText): update tests (#9761) * chore(HelperText): update tests * break out helpertextitem tests, update tests * updates * fix lint * fix(Chip): update tooltip vis when chip updates (#9819) * fix(Chip): enable tooltip when chip updates * fix casting * chore(DescriptionList): update tests (#9753) * chore(DescriptionList): update tests * break out tests, pr feedback * updates * add autofit width mod test * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(TreeView): updated tests (#9773) * chore(TreeView): updated tests * Added tests for TreeViewListItem * Added tests for TreeViewRoot and TreeView * Updated snapshots and queries * chore(Table) convert demos to ts (#9621) * chore(table) convert to TS chore(DashboardWrapper) convert to TS chore(Table) convert demos to TS delete superfluous dashboard components declare as ts files remove duplicate ids fix import errors, WIP build errors sync toolbar demo with main * update import paths * fix more import paths * try import from dist/esm * fix build * convert remaining table demos to ts, WIP draggable logic * revert col management with draggable to previous dnd implementation * align file names with demo names, cleanup types, fix TS errors in demo files * update fileNames in table.md * PR feedback from Eric * fix category dropdown * fix demos, remove table actions that do not support main purpose of column management demos * add fix for a11y tests as suggested by Eric * update toolbar snap * add param type to labelText --------- Co-authored-by: Jenny <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9829) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(select): Adds documentation to React examples. (#9536) * fix conflicts * docs(select): Adds documentation for React examples. * Adds content to new select React examples. * Updates typeahead with create example. * Clarify mult typeahead with create content. * Finalizing wording. * Updates content from review. --------- Co-authored-by: nicolethoen <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9833) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update devdependencies (#9837) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix link to patternfly community contributors document (#9840) * chore(deps): update devdependencies (#9846) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Table): make tooltip prop consistent (#9803) * fix(Table): make tooltip prop consistent * make tooltip ReactNode and add tooltipProps to Th * add prop to useEffect * fix logic for keyboard focus * fix useeffect * chore(DataList): convert data list react demo to TS (#9818) * convert data list react demo to TS * update function component name to match file * fix(AlertGroupDemo): crashed when adding default alerts (#9826) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @types/jest to v29.5.11 (#9854) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Popover returnFocusOnDeactivate prop (#9865) Closes #9863 * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.7 (#9867) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9873) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(MenuItem): Add download to MenuItem (#9892) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(Accordion): added toggle alignment functionality (#9877) * feat(Accordion): added toggle alignment functionality * Updated prop name and description * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add primary button with icon to button docs (#9871) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Chip): prevented duplicate ID being applied (#9886) * fix(Chip): prevented duplicate ID being applied * Updated snapshot * Updated integration test selector * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(expandablesection): Added a demo to show how to use expandable section to create an expandable text component. (#9887) * chore(expandablesection): Added a demo to show how to use expandable section to create an expandable text component. * Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md Co-authored-by: Erin Donehoo <[email protected]> * Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md Co-authored-by: Erin Donehoo <[email protected]> * Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md Co-authored-by: Erin Donehoo <[email protected]> --------- Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Titani Labaj <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(CodeEditor): use new monaco package (#9842) * feat(CodeEditor): use new monaco package * remove commented code * fix integration * update tests and mock out editor * move to direct dependency * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * feat(Modal next): Introduce a next composable Modal (#9852) * feat(Modal next): Introduce a next composble Modal * upodate for failing tests * add integration test * updates from review * updates from Erin's comments * Updates from comments * chore(build): Fix lint issues (#9938) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(DragDrop): new drag drop styling fixes (#9784) * feat(DragDrop): introduce new package and deprecate old implementation * refactor a bunch * style fixes * fix lint errors * fix lint * update snap * update duallistselector example, try exporting interface from separate file * bump versions in dragdrop for mismatch * fix versions * pr feedback * fix versions after merge * version update after rebase * update md * move into next folder for docgen * update version after rebase * update ver after rebase * update ver after rebase * update ver after rebase * remove unused prop, update wording * move some examples to demos * update ver after rebase * update new demos text * update wording p1 * update wording p2 * update wording p3 * update wording p4 * fix links * remove beta flags since page is beta * update ver after rebase --------- Co-authored-by: nicolethoen <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * Add support for isLabelWrapped and component in Checkbox / Radio (#9830) * feat(Checkbox): add support for isLabelWrapped and isLabelBeforeButton * feat(Radio): add support for component * refactor(Radio/Checkbox): check isLabelBeforeButton only once * feat(Radio/Checkbox): add support for component === "label" behaving the same as isLabelWrapped * docs(Radio/Checkbox): update props description * test(Checkbox): add unit tests * test(Checkbox): unit test * test(Radio): unit tests * chore(build): Fix lint errors (#9950) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9932) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Popover): doc click event (#9952) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * Update react-core dist/dynamic to include exported styles (#9939) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9955) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * FileUploadField fix to set name attribute on input element (#9941) * FileUploadField name attribute fix * update snapshots * prevent breaking change --------- Co-authored-by: nicolethoen <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9967) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Victory dependencies (#9963) * feat(charts): Victory dependency update Closes #9960 * chore(charts): update lodash dependency * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Clipboard copy): Fixed regression with updating main content when expanded (#9975) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(ClipboardCopy): update main content on children change when expanded (#10015) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(DragDrop): fix import warning (#10023) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix accoridan examples * updates to fix docs * bump docs-framework version --------- Signed-off-by: gitdallas <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Jeff Puzzo <[email protected]> Co-authored-by: adamviktora <[email protected]> Co-authored-by: Mark Franceschelli <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kells512 <[email protected]> Co-authored-by: nicolethoen <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Yurith Rubio <[email protected]> Co-authored-by: Joachim Schuler <[email protected]> Co-authored-by: Robb Hamilton <[email protected]> Co-authored-by: Donald Labaj <[email protected]> Co-authored-by: Vojtech Szocs <[email protected]> Co-authored-by: James Talton <[email protected]> Co-authored-by: Dan Labrecque <[email protected]> Co-authored-by: Titani <[email protected]>
dlabaj
added a commit
that referenced
this pull request
Apr 19, 2024
* fix(RTL): added right-to-left page demo (#9694) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Wizard): onStepChange - skip isDisabled & isHidden (#9748) * fix(Text input): Added aria-expanded (#9705) * fix(Text input): Added aria-expanded * add interface * updates from review * fix(Notification Drawer): Added screen reader text for notification drawer item read state (#9569) * fix(Notification Drawer): Added screen reader text for notification drawer item read state * fix snapshot * Update prop description * add aria-live * update snapshots * feat(Wizard): ability to add props to WizardFooter buttons (#9709) * feat: ability to add props to WizardFooter buttons * fix(WizardFooter): null check * fix(Wizard): simpler design of adding footer buttons props * test(Wizard): can add props to footer buttons * docs(WizardFooter): move comment so docs have correct description * refactor(WizardFooter): move FooterButtonProps to types file * chore(Divider): update tests to new standards (#9714) * chore(Divider): update tests to new standards * changes from PR review * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(TreeView): define button type (#9770) * bug(build): fixed built ESM files importing CJS files from react-styles (#9347) * bug(build): fixed built ESM files importing CJS files from react-styles * edited yarn.lock to invalidate deps cache in GH actions * excluded file extensions from react-styles path transform in ESM build * updated jest config to transform .mjs files * updated pr action to invalidate deps cache if package files added/edited * chore(deps): Add ts-node to support executing typescript files directly * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - [email protected] * chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.4 (#9780) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * feat(Datalist): implement full page Basic demo to match HTML #9048 (#9087) * feat(Datalist): implement full page Basic demo to match HTML #9048 * fix syntax error * comments applied * comments applied * comments applied * comments applied * \xa0 comments applied * move key per review comments * address PR comments * revert change to package.json * Converted basic demo to TS --------- Co-authored-by: nicolethoen <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> * fix(ClipboardCopy): kepp caret position (#9772) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9757) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.5 (#9806) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update devdependencies (#9800) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(DatePicker): updated logic for parsing and focus management (#9794) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(PrimaryDetail): convert demos to TS (#9787) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(misc): clean up instances of Array.apply (#9798) * clean up instances of Array.apply * rename item to value * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(eslint): Added React Testing Library linter plugin (#9805) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(DataList): update tests (#9672) * add spread prop test, update test * chore(DataList): update tests * fix merge error * break out into separate files, pr feedback * updates * fix some example ids * minor test updates * revert action change * bug(ClipboardCopy): change children type to string (#9743) * bug(ClipboardCopy): change children type to string Signed-off-by: gitdallas <[email protected]> * fix clipboardcopyexpanded to work with string children Signed-off-by: gitdallas <[email protected]> * refactor a bit * fix bad rebase --------- Signed-off-by: gitdallas <[email protected]> * chore(deps): update devdependencies (#9817) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix Search Input - composable advanced search demo (#9484) * Search Input - composable advanced search fix date * remove isFill from datePicker * docs(custom menu): add example with search input inline filtering (#9687) * docs(custom menu): add example with search input inline filtering * refactor(demo menu): rename to InlineSearchFilterMenuDemo * chore(HelperText): update tests (#9761) * chore(HelperText): update tests * break out helpertextitem tests, update tests * updates * fix lint * fix(Chip): update tooltip vis when chip updates (#9819) * fix(Chip): enable tooltip when chip updates * fix casting * chore(DescriptionList): update tests (#9753) * chore(DescriptionList): update tests * break out tests, pr feedback * updates * add autofit width mod test * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(TreeView): updated tests (#9773) * chore(TreeView): updated tests * Added tests for TreeViewListItem * Added tests for TreeViewRoot and TreeView * Updated snapshots and queries * chore(Table) convert demos to ts (#9621) * chore(table) convert to TS chore(DashboardWrapper) convert to TS chore(Table) convert demos to TS delete superfluous dashboard components declare as ts files remove duplicate ids fix import errors, WIP build errors sync toolbar demo with main * update import paths * fix more import paths * try import from dist/esm * fix build * convert remaining table demos to ts, WIP draggable logic * revert col management with draggable to previous dnd implementation * align file names with demo names, cleanup types, fix TS errors in demo files * update fileNames in table.md * PR feedback from Eric * fix category dropdown * fix demos, remove table actions that do not support main purpose of column management demos * add fix for a11y tests as suggested by Eric * update toolbar snap * add param type to labelText --------- Co-authored-by: Jenny <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9829) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(select): Adds documentation to React examples. (#9536) * fix conflicts * docs(select): Adds documentation for React examples. * Adds content to new select React examples. * Updates typeahead with create example. * Clarify mult typeahead with create content. * Finalizing wording. * Updates content from review. --------- Co-authored-by: nicolethoen <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9833) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update devdependencies (#9837) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix link to patternfly community contributors document (#9840) * chore(deps): update devdependencies (#9846) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Table): make tooltip prop consistent (#9803) * fix(Table): make tooltip prop consistent * make tooltip ReactNode and add tooltipProps to Th * add prop to useEffect * fix logic for keyboard focus * fix useeffect * chore(DataList): convert data list react demo to TS (#9818) * convert data list react demo to TS * update function component name to match file * fix(AlertGroupDemo): crashed when adding default alerts (#9826) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @types/jest to v29.5.11 (#9854) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Popover returnFocusOnDeactivate prop (#9865) Closes #9863 * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.7 (#9867) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9873) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(MenuItem): Add download to MenuItem (#9892) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(Accordion): added toggle alignment functionality (#9877) * feat(Accordion): added toggle alignment functionality * Updated prop name and description * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add primary button with icon to button docs (#9871) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Chip): prevented duplicate ID being applied (#9886) * fix(Chip): prevented duplicate ID being applied * Updated snapshot * Updated integration test selector * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(expandablesection): Added a demo to show how to use expandable section to create an expandable text component. (#9887) * chore(expandablesection): Added a demo to show how to use expandable section to create an expandable text component. * Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md Co-authored-by: Erin Donehoo <[email protected]> * Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md Co-authored-by: Erin Donehoo <[email protected]> * Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md Co-authored-by: Erin Donehoo <[email protected]> --------- Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Titani Labaj <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(CodeEditor): use new monaco package (#9842) * feat(CodeEditor): use new monaco package * remove commented code * fix integration * update tests and mock out editor * move to direct dependency * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * feat(Modal next): Introduce a next composable Modal (#9852) * feat(Modal next): Introduce a next composble Modal * upodate for failing tests * add integration test * updates from review * updates from Erin's comments * Updates from comments * chore(build): Fix lint issues (#9938) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(DragDrop): new drag drop styling fixes (#9784) * feat(DragDrop): introduce new package and deprecate old implementation * refactor a bunch * style fixes * fix lint errors * fix lint * update snap * update duallistselector example, try exporting interface from separate file * bump versions in dragdrop for mismatch * fix versions * pr feedback * fix versions after merge * version update after rebase * update md * move into next folder for docgen * update version after rebase * update ver after rebase * update ver after rebase * update ver after rebase * remove unused prop, update wording * move some examples to demos * update ver after rebase * update new demos text * update wording p1 * update wording p2 * update wording p3 * update wording p4 * fix links * remove beta flags since page is beta * update ver after rebase --------- Co-authored-by: nicolethoen <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * Add support for isLabelWrapped and component in Checkbox / Radio (#9830) * feat(Checkbox): add support for isLabelWrapped and isLabelBeforeButton * feat(Radio): add support for component * refactor(Radio/Checkbox): check isLabelBeforeButton only once * feat(Radio/Checkbox): add support for component === "label" behaving the same as isLabelWrapped * docs(Radio/Checkbox): update props description * test(Checkbox): add unit tests * test(Checkbox): unit test * test(Radio): unit tests * chore(build): Fix lint errors (#9950) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9932) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Popover): doc click event (#9952) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * Update react-core dist/dynamic to include exported styles (#9939) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9955) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * FileUploadField fix to set name attribute on input element (#9941) * FileUploadField name attribute fix * update snapshots * prevent breaking change --------- Co-authored-by: nicolethoen <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update devdependencies (#9967) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Victory dependencies (#9963) * feat(charts): Victory dependency update Closes #9960 * chore(charts): update lodash dependency * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Clipboard copy): Fixed regression with updating main content when expanded (#9975) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(ClipboardCopy): update main content on children change when expanded (#10015) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(DragDrop): fix import warning (#10023) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: prevent console warning in checkbox & radio (#10048) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * Revert release attempt (#10062) * Revert "chore(release): releasing packages [ci skip]" This reverts commit 30b52a0. * Revert "chore(release): releasing packages [ci skip]" This reverts commit b2e8cc2. * fix: version of eslint-plugin-patternfly-react * chore: do promotion in two steps [ci skip] * fix: white space change to trigger prerelease * chore(release): releasing packages [ci skip] - [email protected] * chore(build): add script to stop exporting demos in built files (#10063) * chore(build): add script to stop exporting demos in built files * chore(build): update to remove demo exports from shipped TS files also * chore(ci): update deployment to clean exports of demos * fix: whitespace change to trigger prerelease * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update promote script [ci skip] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * chore: prep repo for 5.3 development [ci skip] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix: demo-app version bump issue (#10072) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - [email protected] * fix(charts): adjust for Victory types changes (#10082) Fixes #10078 Fixes #10064 * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat(CodeEditor): pass additional props to monaco-editor, update readme (#10080) * feat(CodeEditor): pass through additional props to Editor * update readme * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat(JumpLinks): support passing a reference to scroll element (#9961) * feat(JumpLinks): support passing a reference to scroll HTMLElement * docs(JumpLinks): update demo to show example with scrollableRef * refactor(JumpLinks): getScrollableElement check if HTMLElement first Co-authored-by: Christian Vogt <[email protected]> * docs(JumpLinks): mention scrollableRef as an option --------- Co-authored-by: Christian Vogt <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Menu toggle): Passed aria label prop value to typeahead variant (#10084) * fix(Menu toggle): Passed aria label prop value to typeahead variant * Fix failing build. Add back default so it does not break consumers * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * Revert "bug(ClipboardCopy): change children type to string (#9743)" (#9895) This reverts commit a414253. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(DualListSelector next): Add next composable Dual List Selector (#9901) * create next environment * updated all examples to be composable * fix double VO for list controls * remove obsolete example files * rename examples * use stronger types for unknowns * remove business logic in main component * fix tests * fixed a11y failures * update composability based on PR review * rm unnecessary funct and update tests * rm prop null assignment and add beta tag * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Popper): check for undefined before accessing (#10086) * chore(chars): Clean up chart examples (#10094) #10093 * bug(Select): expose height and max height props for Menu content (#10075) * bug(Select): expose height and max height props for Menu contnet * add isScrollable prop * Update packages/react-core/src/components/Select/Select.tsx Co-authored-by: Eric Olkowski <[email protected]> --------- Co-authored-by: Eric Olkowski <[email protected]> * feat(SearchInput): Add ability to add id to input in SearchInput component (#9974) * Add ability to add id to SearchInput * Fix typo * Update prop name and add tests * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(DashboardWrapper,DashboardHeader): fix for table imports (#10114) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(deps): bump to latest core (#10116) * chore(deps): bump to latest core * fix(deps): update to latest promoted core version * fix(deps): remove ^ from core version --------- Co-authored-by: Austin Sullivan <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(charts) - ChartLegendTooltip.title has wrong type (#10129) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Select): focus first item when opened by click (#10125) * fix(select): focus first item when opened by click * fix(dropdown/menu/pagination): Update to focus first item on click * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Menu): Fix crash in menu referencing invalid array index (#10153) * Fix crash in menu * Update code best on review feedback * fix linting * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * 🐛 Address datepicker crashing when manually entering year (#10134) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Table): remove demos from package exports (#10165) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(Drag and drop): Marked old impmentation as deprecated (#10145) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(CI): reenable release dist caching (#10148) * chore(deps): update dependency @patternfly/patternfly to v5.3.0-prerelease.4 (#10147) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(docs): fix undefined dashboard wrapper error in demos (#10191) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(react-code-editor): add missing `monaco-editor` dependency (#10198) Signed-off-by: Jon Koops <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.3.0-prerelease.5 (#10200) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(ClipboardCopy): warn when clipboard API is unavailable (#10186) * bug(Select): Remove checkbox from no results found option (#10163) * fix(Table): updated a11y for empty/nontext Th components (#10152) * fix(Table): updated a11y for empty/nontext Th components * Updated additional examples and demos * Added initial Th test file * Updated deprecated snapshots, removed outdated integration test * fix(Table): added ActionsColumn prop to control close on click (#10179) * fix(Table): added ActionsColumn prop to control close on click * Added prop to prevent onOpenChange from being called * fix(TableSortableResponsive demo): end page number (#10170) * fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior (#10066) * fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior * revamp toggle click for checkbox * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * chore: simplify Babel configuration (#10189) Signed-off-by: Jon Koops <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * fix(misc): demos not working due to variables not defined (#10169) * fix(Tabs): broken demos * fix(Banner): broken demo * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(Dropdown): Added support for setting height for dropdown (#10149) * feat(Dropdown): Added support for setting height for dropdown * apply isScrollable to menu if maxMenuHeight or menuHeight is defined * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(GenerateId): add randomness to id generator to prevent id collisions (#10178) * fix(GenerateId): add randomness to id generator to prevent id collisions * chore(docs): Correct prop description * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * feat(templates): add templates package (#10110) * feat(templates): add templates package * revert v6 merge change from previous branch loc * update template location to tab * update ver after rebase * add descriptions to simple select * pr feedback * fix merge * update docs-framework and code-editor * fix jest mocks * back out codeeditor changes * update templates version * update templates version * pr updates * yarn lockfile * update options type * Revert "yarn lockfile" This reverts commit 6839ce2. * lockfile revert * update ver * update type * doc build try 1 * feat(MenuToggle/Select): add status (#10209) * feat(MenuToggle/Select): add status * pr feedback * update menutoggle example * update example desc * mark prop as beta * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(TextArea): remove invalid `onFocus` and `onBlur` props (#10193) Closes #10192 Signed-off-by: Jon Koops <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Card): updated v5 logic to prevent unclickable cards (#10202) * fix(Card): updated v5 logic to prevent unclickable cards * Updated API to have isSelected control selectable card state * Updated cypress test * Updated cypress test * Updated cypress test * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * Convert right-to-left demo to TS (#10164) * covert RTL demo to TS * update component type jsx to tsx * update type js to ts * fix doc build job * implement review comments * fix types * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * feat(Select): add checkbox variant of the simple select template (#10159) * feat(Select): add checkbox variant of the simple select template * chore(Select): rename template * fix(Select): mock generated id in CheckboxSelect snapshot tests * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(Table): added more arialabeling for empty/nontext Table headers (#10205) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat(Label): allow clickable labels to be disabled (#10199) * refactor(Label): rename button to closeButton * feat(Label): allow clickable labels to be disabled * docs(Label): add examples of clickable disabled * refactor(Label): use style token for pf-m-disabled * Prevented anchor onClick firing for AT --------- Co-authored-by: Eric Olkowski <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(GenerateId): revert default behavior change (#10232) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * chore: Create PF6_alpha_bug_request.md [ci skip] * feat(MenuToggle): allow split action toggle text (#10256) * feat(MenuToggle): allow split action toggle text * use var * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(deploy): Redeployed to npm * Update README.md * Update README.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] * update jest config * update template version * update snapshots * update failing snapshot * update framework version * address review comment * update snapshots --------- Signed-off-by: gitdallas <[email protected]> Signed-off-by: Jon Koops <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Jeff Puzzo <[email protected]> Co-authored-by: adamviktora <[email protected]> Co-authored-by: Mark Franceschelli <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kells512 <[email protected]> Co-authored-by: nicolethoen <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Yurith Rubio <[email protected]> Co-authored-by: Joachim Schuler <[email protected]> Co-authored-by: Robb Hamilton <[email protected]> Co-authored-by: Donald Labaj <[email protected]> Co-authored-by: Vojtech Szocs <[email protected]> Co-authored-by: James Talton <[email protected]> Co-authored-by: Dan Labrecque <[email protected]> Co-authored-by: Christian Vogt <[email protected]> Co-authored-by: Jessie <[email protected]> Co-authored-by: Ian Bolton <[email protected]> Co-authored-by: Jon Koops <[email protected]> Co-authored-by: Ajay Pratap <[email protected]>
Closed
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9710
Both
isLabelWrappedandcomponentprops are now supported in Checkbox and Radio. I also added support forisLabelBeforeButtonto checkbox, as we have it in the Radio component.MenuToggleCheckboxwas not rewritten to useCheckboxinternally yet. I had issues with incompatible types. This can possibly be done in a followup PR.